no longer bundle pkgimages for stdlibs with forced bounds checking since Pkg.test no longer defaults to this#60054
Open
KristofferC wants to merge 1 commit intomasterfrom
Open
no longer bundle pkgimages for stdlibs with forced bounds checking since Pkg.test no longer defaults to this#60054KristofferC wants to merge 1 commit intomasterfrom
KristofferC wants to merge 1 commit intomasterfrom
Conversation
…nce Pkg.test no longer defaults to this
dcae480 to
3d7768b
Compare
Member
Author
on CI. Wat? |
Member
|
@KristofferC That exception almost certainly happens because some test uses try/catch to mutate some variable, then resets it before the error is printed. Example: julia> old_depot = copy(DEPOT_PATH)
try
empty!(DEPOT_PATH)
DEPOT_PATH[1]
finally
copy!(DEPOT_PATH, old_depot)
end
ERROR: BoundsError: attempt to access 3-element Vector{String} at index [1] |
Member
Author
|
Yep, I think the test that fails is not really valid anymore with this change. |
Member
|
Triage wants to know how this impacts the runtime of julia-runtest and how many MB it saves (Sam mentioned it saves about 200MB out of a total of 1.1GB install size). It's hard to give an answer without real numbers here. Another option is to have a different tarball for CI than regular users. |
43 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be merged if JuliaLang/Pkg.jl#4494 is merged. Triage might have fun with this one. To be decided for 1.13.
For people that want to test with forced bounds check on e.g. CI they can use the cache artifact functionality to cache those package images.